-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move hive partitioning/multi-file handling outside of readers #20203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
An internal refactor or improvement
python
Related to Python Polars
rust
Related to Rust Polars
labels
Dec 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20203 +/- ##
==========================================
- Coverage 79.13% 78.91% -0.23%
==========================================
Files 1572 1567 -5
Lines 219839 219920 +81
Branches 2462 2465 +3
==========================================
- Hits 173970 173546 -424
- Misses 45301 45806 +505
Partials 568 568 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Dec 7, 2024
coastalwhite
force-pushed
the
refactor/new-hive
branch
from
December 8, 2024 14:58
bd71732
to
99d6a93
Compare
2 tasks
coastalwhite
force-pushed
the
refactor/new-hive
branch
from
December 14, 2024 14:51
3e1e4ae
to
6b8dbcf
Compare
coastalwhite
changed the title
refactor: Move hive partitioning outside of readers
refactor: Move hive partitioning/multi-file handling outside of readers
Dec 18, 2024
This is a very early stage PR exploring whether it is possible to take the hive partitioning out of the readers. This will also make the Hive partitioning complete file type agnostic. Currently, this PR does not do anything unless `POLARS_NEW_HIVE` is set to `1`. Here is a rough todo list. - [x] Row Indexes - [x] Include File Paths - [x] Projection Pushdown - [ ] Slicing - [ ] Hive Predicates - [ ] Lazy Loading of Non-Hive data - [ ] Allow Missing Columns - [ ] Other file types besides Parquet - [ ] New streaming engine sink
coastalwhite
force-pushed
the
refactor/new-hive
branch
from
December 19, 2024 08:56
375766a
to
aca6631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very early stage PR exploring whether it is possible to take the multi-file handling and hive partitioning out of the readers. This will also make the multi-file and hive partitioning completely file type agnostic.
Currently, this PR does not do anything unless
POLARS_NEW_MULTIFILE
is set to1
.Here is a rough todo list.
ping @ritchie46, @nameexhaustion