-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rust): Fix null handling in collect_statistics
of parquet reader
#20362
base: main
Are you sure you want to change the base?
fix(rust): Fix null handling in collect_statistics
of parquet reader
#20362
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20362 +/- ##
==========================================
- Coverage 79.13% 78.90% -0.23%
==========================================
Files 1572 1567 -5
Lines 219839 219920 +81
Branches 2462 2465 +3
==========================================
- Hits 173970 173537 -433
- Misses 45301 45815 +514
Partials 568 568 ☔ View full report in Codecov by Sentry. |
@coastalwhite is this ok? |
I will look at it. I would really like to make a test with an MRE before merging this. I am pretty sure if I look at the code for a second I can find one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an okay fix for now. It should really be handled in #20203 by filling in a null
.
fd89933
to
45e5cfa
Compare
45e5cfa
to
08d86af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think this should just be fixed by #20203. This kind of makes it impossible to do predicate pushdown with missing columns.
ae28fd2
to
c7808d3
Compare
@coastalwhite thanks for the quick review and the MRE! |
Fixes #20361