Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename argument drop_nulls to ignore_nulls in $all() and $any() #1050

Merged
merged 4 commits into from
May 22, 2024
Merged

Rename argument drop_nulls to ignore_nulls in $all() and $any() #1050

merged 4 commits into from
May 22, 2024

Conversation

etiennebacher
Copy link
Collaborator

Also improve docs and add tests

eitsupi
eitsupi requested changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
But I think we need to wait a while and make a patch release before merging this breaking change.

R/expr__expr.R Outdated Show resolved Hide resolved
@eitsupi eitsupi added this to the 0.17 milestone Apr 18, 2024
@etiennebacher etiennebacher marked this pull request as draft April 22, 2024 06:20
@etiennebacher etiennebacher mentioned this pull request Apr 26, 2024
Merged
@etiennebacher etiennebacher mentioned this pull request May 6, 2024
Merged
@eitsupi eitsupi marked this pull request as ready for review May 22, 2024 13:17
@eitsupi eitsupi merged commit 3d2a333 into main May 22, 2024
23 of 25 checks passed
@eitsupi eitsupi deleted the any-all-ignore-nulls branch May 22, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
2 participants
@etiennebacher @eitsupi