Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Enum datatype #1061

Merged
merged 7 commits into from
Apr 26, 2024
Merged

Implement Enum datatype #1061

merged 7 commits into from
Apr 26, 2024

Conversation

etiennebacher
Copy link
Collaborator

Close #668

eitsupi
eitsupi approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@etiennebacher
merge main
c17aa15 
Merge branch 'main' into enum-datatype

# Conflicts:
#	NEWS.md
@etiennebacher etiennebacher marked this pull request as ready for review April 26, 2024 15:13
@eitsupi
Copy link
Collaborator

eitsupi commented Apr 26, 2024

@etiennebacher Do you think it is ok to do the release work after this has been merged?

@etiennebacher
Copy link
Collaborator Author

Would it be for 0.16.2 or 0.17.0? If 0.16.2 yes, but if 0.17.0 we can merge #1050 and #1053 first

@eitsupi
Copy link
Collaborator

eitsupi commented Apr 26, 2024

Sorry for the confusion, I meant 0.16.2.
I think 0.17.0 would be good after Rust Polars 0.40.0 release, as the polars repository shows some breaking changes merged after 0.39.2.

@etiennebacher etiennebacher merged commit 113f07e into main Apr 26, 2024
23 of 25 checks passed
@etiennebacher etiennebacher deleted the enum-datatype branch April 26, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Enum data type
2 participants
@etiennebacher @eitsupi