formally specify WeightLimit enum variants #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadanda
approved these changes
Jul 12, 2024
| @@ -1039,7 +1039,7 @@ Errors: | |||
|
|
|||
| A directive to indicate that the origin expects free execution of the message. | |||
|
|
|||
| At execution time, this instruction just does a check on the Origin register. However, at the barrier stage, messages starting with this instruction can be disregarded if the origin is not acceptable for free execution, or the `weight_limit` is `Limited` and insufficient. | |||
| At execution time, this instruction just does a check on the Origin register. However, at the barrier stage, messages starting with this instruction can be disregarded if the origin is not acceptable for free execution, or the `weight_limit` is `Limited(w)` and `w` is insufficient weight. | |||
There was a problem hiding this comment.
Suggested change
| At execution time, this instruction just does a check on the Origin register. However, at the barrier stage, messages starting with this instruction can be disregarded if the origin is not acceptable for free execution, or the `weight_limit` is `Limited(w)` and `w` is insufficient weight. | |
| At execution time, this instruction just does a check on the Origin register. However, at the barrier stage, messages starting with this instruction can be disregarded if the origin is not acceptable for free execution, or the `weight_limit` is `Limited(weight)` and `weight` is insufficient. |
maybe subjective
serban300
approved these changes
Jul 12, 2024
bkontur
approved these changes
Jul 12, 2024
|
yes, the README.md is the actual formal spec and requires updating on multiple sections - we need to be much more active with its maintainance |
|
/merge |
bkchr
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify specification in case of
WeightLimit.Caught by @mrshiposha in #55 (comment)