Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formally specify WeightLimit enum variants #61

Merged
merged 1 commit into from
Jul 12, 2024
Merged

formally specify WeightLimit enum variants #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ Pay for the execution of some XCM `xcm` and `orders` with up to `weight` picosec
Operands:

- `fees: Asset`: The asset(s) to remove from the Holding Register to pay for fees.
- `weight_limit: WeightLimit`: The maximum amount of weight to purchase; this must be at least the expected maximum weight of the total XCM to be executed for the `AllowTopLevelPaidExecutionFrom` barrier to allow the XCM be executed.
- `weight_limit: WeightLimit`: The maximum amount of weight to purchase; this must be at least the expected maximum weight of the total XCM to be executed for the `AllowTopLevelPaidExecutionFrom` barrier to allow the XCM be executed. `WeightLimit` is an enum that can specify either `Limited(Weight)` or `Unlimited` weight limits.

Kind: *Command*

Expand Down Expand Up @@ -1039,7 +1039,7 @@ Errors:

A directive to indicate that the origin expects free execution of the message.

At execution time, this instruction just does a check on the Origin register. However, at the barrier stage, messages starting with this instruction can be disregarded if the origin is not acceptable for free execution, or the `weight_limit` is `Limited` and insufficient.
At execution time, this instruction just does a check on the Origin register. However, at the barrier stage, messages starting with this instruction can be disregarded if the origin is not acceptable for free execution, or the `weight_limit` is `Limited(w)` and `w` is insufficient weight.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
At execution time, this instruction just does a check on the Origin register. However, at the barrier stage, messages starting with this instruction can be disregarded if the origin is not acceptable for free execution, or the `weight_limit` is `Limited(w)` and `w` is insufficient weight.
At execution time, this instruction just does a check on the Origin register. However, at the barrier stage, messages starting with this instruction can be disregarded if the origin is not acceptable for free execution, or the `weight_limit` is `Limited(weight)` and `weight` is insufficient.

maybe subjective


Operands:
- `weight_limit: WeightLimit`
Expand Down