Create use thresholds hook and use correct thresholds for reject origin #4588
Conversation
# Conflicts: # packages/page-bounties/src/BountyActions/ProposeCuratorAction.tsx
|
I think it looks fine as-is with the use. However need to just be awake and go through line-by-line where used and compare to the originals to ensure the logic still matches where used. Will get to it this weekend. |
| } | ||
|
|
||
| export function getAtLeastThresholdMembersCount (membersCount: number, thresholdRatio: number): number { | ||
| return Math.ceil(membersCount * thresholdRatio); |
There was a problem hiding this comment.
shall we add if (membersCount === 0) { return 0; } here, as it's done above?
| }; | ||
| export interface Threshold { | ||
| value: number; | ||
| option: 'AtLeast' | 'MoreThan'; |
There was a problem hiding this comment.
does it make sense to create an enum for these options? for simplifying further maintaining and exclude typos
|
Closing. Will pull in relevant ideas into #6924 The linked PR in itself also needs to get up-to-date with master. It may actually just get "some" fixes and not be fully completed since the ecosystem is moving to the gov 2 model with less reliance on these configs. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.