Ensure evenly divisible thresholds are adjusted #6924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A quick fix in #9419. Instead of using |
|
If you want to find a chain with even council seats, please try Phala (it has 8 members): |
h4x3rotab
reviewed
May 9, 2023
Comment on lines
+58
to
+73
| export function calcThreshold (members: unknown[], threshold: number): BN { | ||
| const frac = members.length * threshold; | ||
| const ceil = Math.ceil(frac); | ||
|
|
||
| return new BN( | ||
| Math.min( | ||
| members.length, | ||
| ceil + ( | ||
| // for evenly divisible, adjust upwards | ||
| Math.floor(frac) === ceil | ||
| ? 1 | ||
| : 0 | ||
| ) | ||
| ) | ||
| ); | ||
| } |
There was a problem hiding this comment.
The function is identical to:
function calcThreshold (members: unknown[], threshold: number): BN {
return new BN(
Math.min(
members.length,
Math.floor(members.length * threshold) + 1
)
);
}Tested with:
for (let len = 0; len < 10; len++) {
for (let threshold = 0; threshold <= 1; threshold += 0.1) {
// assert left(members, threshold) == right(members, threshold)
}
}
|
Closing this PR as it appears to be outdated. If the problem persists, a new PR can be opened with updated details. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6828
Closes #4588
The correct solution is probably to carry the
>and>=but it certainly makes things a lot more complex. In this implementation we actually DRY things a lot. So could be re-visited possibly if really needed. (The hook in the linked PR could be interesting, instead ofuseMemoeverywhere.