Web3ApiClient - Preload API resolvers #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerfZael
changed the title
nerfZael
changed the title
nerfZael
commented
Mar 25, 2022
| private deserializeOptions?: DeserializeManifestOptions, | ||
| disablePreloadResolvers?: boolean | ||
| ) { | ||
| if (disablePreloadResolvers) { |
There was a problem hiding this comment.
This is a sort of hacky solution to the problem of using the aggregator in core-js tests
There was a problem hiding this comment.
hmmm, should we use a TEST environment variable maybe?
There was a problem hiding this comment.
Maybe, but I think this is also has usecases elsewhere, eg a performance increase if you know all of your resolvers are local
nerfZael
requested review from
dOrgJelli,
krisbitney and
namesty
as code owners
dOrgJelli
requested changes
Apr 8, 2022
There was a problem hiding this comment.
This all looks really good!
I spent some time restructuring the terminology to something that I think makes more sense to new users. Would love to discuss here: #806
If you're okay with these proposed changes, I'm good with this PR :D
Everything looks great 💯
…te-recursion URI Resolver Terminology Updates
dOrgJelli
approved these changes
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #715
Unblocks: polywrap/demos#23