Skip to content

Commit

Permalink
Merge pull request iced-rs#1524 from bungoboingo/fix/gradients_wasm
Browse files Browse the repository at this point in the history
Additional cfg for wasm target for gradients
  • Loading branch information
hecrj authored Nov 15, 2022
2 parents 042020b + 365f37a commit 5b0dfcd
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 3 deletions.
1 change: 1 addition & 0 deletions glow/src/triangle.rs
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ impl Pipeline {
triangle::Style::Solid(color) => {
self.programs.solid.use_program(gl, color, &transform);
}
#[cfg(not(target_arch = "wasm32"))]
triangle::Style::Gradient(gradient) => {
self.programs
.gradient
Expand Down
6 changes: 5 additions & 1 deletion graphics/src/triangle.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
//! Draw geometry using meshes of triangles.
use crate::{Color, Gradient};
use crate::Color;
#[cfg(not(target_arch = "wasm32"))]
use crate::Gradient;

use bytemuck::{Pod, Zeroable};

Expand Down Expand Up @@ -27,6 +29,7 @@ pub struct Vertex2D {
pub enum Style {
/// Fill a primitive with a solid color.
Solid(Color),
#[cfg(not(target_arch = "wasm32"))]
/// Fill a primitive with an interpolated color.
Gradient(Gradient),
}
Expand All @@ -37,6 +40,7 @@ impl From<Color> for Style {
}
}

#[cfg(not(target_arch = "wasm32"))]
impl From<Gradient> for Style {
fn from(gradient: Gradient) -> Self {
Self::Gradient(gradient)
Expand Down
1 change: 1 addition & 0 deletions graphics/src/widget/canvas/frame.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ impl Transform {
fn transform_style(&self, style: triangle::Style) -> triangle::Style {
match style {
triangle::Style::Solid(color) => triangle::Style::Solid(color),
#[cfg(not(target_arch = "wasm32"))]
triangle::Style::Gradient(gradient) => {
triangle::Style::Gradient(self.transform_gradient(gradient))
}
Expand Down
7 changes: 7 additions & 0 deletions wgpu/src/buffer/dynamic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ impl<T: ShaderType + WriteInto> Buffer<T> {
)
}

#[cfg(not(target_arch = "wasm32"))]
/// Creates a new dynamic storage buffer.
pub fn storage(device: &wgpu::Device, label: &'static str) -> Self {
Buffer::new(
Expand Down Expand Up @@ -91,6 +92,7 @@ impl<T: ShaderType + WriteInto> Buffer<T> {
Internal::Uniform(_) => {
wgpu::BufferUsages::UNIFORM | wgpu::BufferUsages::COPY_DST
}
#[cfg(not(target_arch = "wasm32"))]
Internal::Storage(_) => {
wgpu::BufferUsages::STORAGE | wgpu::BufferUsages::COPY_DST
}
Expand Down Expand Up @@ -154,6 +156,8 @@ impl<T: ShaderType + WriteInto> Buffer<T> {
// Currently supported dynamic buffers.
enum Internal {
Uniform(encase::DynamicUniformBuffer<Vec<u8>>),
#[cfg(not(target_arch = "wasm32"))]
//storage buffers are not supported on wgpu wasm target (yet)
Storage(encase::DynamicStorageBuffer<Vec<u8>>),
}

Expand All @@ -168,6 +172,7 @@ impl Internal {
.write(value)
.expect("Error when writing to dynamic uniform buffer.")
as u32,
#[cfg(not(target_arch = "wasm32"))]
Internal::Storage(buf) => buf
.write(value)
.expect("Error when writing to dynamic storage buffer.")
Expand All @@ -179,6 +184,7 @@ impl Internal {
pub(super) fn get_ref(&self) -> &Vec<u8> {
match self {
Internal::Uniform(buf) => buf.as_ref(),
#[cfg(not(target_arch = "wasm32"))]
Internal::Storage(buf) => buf.as_ref(),
}
}
Expand All @@ -190,6 +196,7 @@ impl Internal {
buf.as_mut().clear();
buf.set_offset(0);
}
#[cfg(not(target_arch = "wasm32"))]
Internal::Storage(buf) => {
buf.as_mut().clear();
buf.set_offset(0);
Expand Down
15 changes: 13 additions & 2 deletions wgpu/src/triangle.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
//! Draw meshes of triangles.
#[cfg(not(target_arch = "wasm32"))]
mod gradient;
mod msaa;
mod solid;
Expand Down Expand Up @@ -27,6 +28,8 @@ pub(crate) struct Pipeline {
/// Supported triangle pipelines for different fills.
pub(crate) struct PipelineList {
solid: solid::Pipeline,
/// Gradients are currently not supported on WASM targets due to their need of storage buffers.
#[cfg(not(target_arch = "wasm32"))]
gradient: gradient::Pipeline,
}

Expand All @@ -40,8 +43,11 @@ impl PipelineList {
/// Resets each pipeline's buffers.
fn clear(&mut self) {
self.solid.buffer.clear();
self.gradient.uniform_buffer.clear();
self.gradient.storage_buffer.clear();
#[cfg(not(target_arch = "wasm32"))]
{
self.gradient.uniform_buffer.clear();
self.gradient.storage_buffer.clear();
}
}

/// Writes the contents of each pipeline's CPU buffer to the GPU, resizing the GPU buffer
Expand All @@ -53,6 +59,7 @@ impl PipelineList {
encoder: &mut wgpu::CommandEncoder,
) {
self.solid.write(device, staging_belt, encoder);
#[cfg(not(target_arch = "wasm32"))]
self.gradient.write(device, staging_belt, encoder);
}
}
Expand All @@ -79,6 +86,7 @@ impl Pipeline {
index_strides: Vec::new(),
pipelines: PipelineList {
solid: solid::Pipeline::new(device, format, antialiasing),
#[cfg(not(target_arch = "wasm32"))]
gradient: gradient::Pipeline::new(device, format, antialiasing),
},
}
Expand Down Expand Up @@ -145,6 +153,7 @@ impl Pipeline {
triangle::Style::Solid(color) => {
self.pipelines.solid.push(transform, color);
}
#[cfg(not(target_arch = "wasm32"))]
triangle::Style::Gradient(gradient) => {
self.pipelines.gradient.push(transform, gradient);
}
Expand Down Expand Up @@ -186,6 +195,7 @@ impl Pipeline {
});

let mut num_solids = 0;
#[cfg(not(target_arch = "wasm32"))]
let mut num_gradients = 0;
let mut last_is_solid = None;

Expand Down Expand Up @@ -216,6 +226,7 @@ impl Pipeline {

num_solids += 1;
}
#[cfg(not(target_arch = "wasm32"))]
triangle::Style::Gradient(_) => {
if last_is_solid.unwrap_or(true) {
self.pipelines
Expand Down

0 comments on commit 5b0dfcd

Please sign in to comment.