Skip to content

Commit

Permalink
ALSA: fireface: fix return value in error path of isochronous resourc…
Browse files Browse the repository at this point in the history
…es reservation

Even if isochronous resources reservation fails, error code doesn't return
in pcm.hw_params callback.

Cc: <stable@vger.kernel.org> #5.3+
Fixes: 55162d2 ("ALSA: fireface: reserve/release isochronous resources in pcm.hw_params/hw_free callbacks")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20191209151655.GA8090@workstation
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
takaswie authored and tiwai committed Dec 9, 2019
1 parent 59a126a commit 4801363
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/firewire/fireface/ff-pcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ static int pcm_hw_params(struct snd_pcm_substream *substream,
mutex_unlock(&ff->mutex);
}

return 0;
return err;
}

static int pcm_hw_free(struct snd_pcm_substream *substream)
Expand Down

0 comments on commit 4801363

Please sign in to comment.