Skip to content

Commit

Permalink
ALSA: oxfw: fix return value in error path of isochronous resources r…
Browse files Browse the repository at this point in the history
…eservation

BugLink: https://bugs.launchpad.net/bugs/1856869

commit 59a126a upstream.

Even if isochronous resources reservation fails, error code doesn't return
in pcm.hw_params callback.

Cc: <stable@vger.kernel.org> #5.3+
Fixes: 4f380d0 ("ALSA: oxfw: configure packet format in pcm.hw_params callback")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20191209151655.GA8090@workstation
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
  • Loading branch information
takaswie authored and marcelocerri committed Jan 17, 2020
1 parent 9762280 commit c5ee92e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/firewire/oxfw/oxfw-pcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ static int pcm_playback_hw_params(struct snd_pcm_substream *substream,
mutex_unlock(&oxfw->mutex);
}

return 0;
return err;
}

static int pcm_capture_hw_free(struct snd_pcm_substream *substream)
Expand Down

0 comments on commit c5ee92e

Please sign in to comment.