Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix equality checks and setting of I18n.locale #355

Closed
aaronskiba opened this issue Jul 11, 2023 · 1 comment
Closed

Fix equality checks and setting of I18n.locale #355

aaronskiba opened this issue Jul 11, 2023 · 1 comment
Assignees
@lagoan @aaronskiba
Labels
bug Something isn't working

Comments

@aaronskiba
Copy link
Collaborator

aaronskiba commented Jul 11, 2023 •
edited
Loading

The file, application_helper.rb includes several if I18n.locale == 'fr_CA' statements. However, this statement seems to evaluate to false, even when the app is set to French.

A cause for this issue may be that I18n.locale.class evaluates to a Symbol, rather than a String. Additionally, when the app is set to French, I18n.locale.to_s returns “fr-CA” rather than “fr_CA”.
@aaronskiba aaronskiba added the bug Something isn't working label Jul 11, 2023
@lagoan lagoan mentioned this issue Jul 12, 2023
Closed
@aaronskiba
Copy link
Collaborator Author

Problem persists after merging with RoadMap Release v3.3.1.

@aaronskiba aaronskiba mentioned this issue Jul 20, 2023
Closed
aaronskiba added a commit that referenced this issue Jul 21, 2023
@aaronskiba
Fix issue #355
32b1484 
#trivial
@aaronskiba aaronskiba mentioned this issue Jul 21, 2023
Merged
aaronskiba added a commit that referenced this issue Jul 24, 2023
@aaronskiba
Merge pull request #394 from portagenetwork/aaron/issues/355
0ec9829 
Fix issue #355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lagoan lagoan

@aaronskiba aaronskiba

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lagoan @aaronskiba