Fix issue #355 #394
Fix issue #355 #394
Conversation
|
This implementation doesn't use the Service described in this issue: #390 However, it may be a cleaner approach. |
We will not be using the provided LocaleService. Thus, issue #390 can be closed.
|
Issue #355 now appears to be fixed. However, other anomalies are noticed after testing (Issue #397 has been created as a result):
Also, other link-related issues (#385 and #388) still exist. |
This is a temporary change until the corresponding French terms route is available.
| 'https://assistant.portagenetwork.ca/terms' | ||
| end | ||
| 'https://assistant.portagenetwork.ca/terms' | ||
| # if I18n.locale == :'fr-CA' |
There was a problem hiding this comment.
We can leave this code commented out as we know there is a change coming in soon. We should add a comment mentioning this though.
There was a problem hiding this comment.
Cool. I had a little something written there, but this is probably clearer.
I guess adding # TODO is useful too because it works nicely with rake notes.
| @@ -32,7 +32,7 @@ | |||
| <a href="https://doi.org/10.5281/zenodo.4001018">Primer – Data Management Plan</a> | |||
| </li> | |||
| <li> | |||
| <a href="https://portagenetwork.ca/tools-and-resources/dmp-assistant/how-to-manage-your-data/">How to Manage Your Data</a> | |||
| <a href="#{how_to_manage_your_data_path}">How to Manage Your Data</a> | |||
There was a problem hiding this comment.
Good call on removing the hardcoded url 👍🏽
| @@ -68,7 +68,7 @@ | |||
| }, Rails.configuration.branding[:organisation][:url])%></li> | |||
| <li>•</li> | |||
| <li><a href="<%= contact_us %>"><%= _('Contact us') %></a></li> | |||
| <li><a href="/terms"><%= _('Terms of use') %></a></li> | |||
| <li><a href="<%= terms_of_use_path %>"><%= _('Terms of use') %></a></li> | |||
There was a problem hiding this comment.
Again, good call on removing hardocded urls.
Fixes issue #355