Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portals server client loader #231

Merged
merged 14 commits into from
Aug 10, 2023

Conversation

MKLepium
Copy link
Contributor

Shopping Cart Client works.

View README for instructions and issues.

Copy link
Member

@jspenger jspenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some smaller notes, can be merged after changes.

Here are some additional comments:
We should have some scripts that make it easy to run the VLDB demo. I suggest creating a sub-directory scenario1 in the vldb-demo repo: https://github.com/portals-project/vldb2023demo. Where these scripts are included, and should likely have the following:

  • A script that installs everything that is necessary.
  • A script that starts minikube and starts docker.
  • A script that launches the kubernetes deployment.
  • A script that, when started, starts observing the logs of the kubernetes deployment; so that we can inspect what is happening on the server.
  • A script that cleans up the kubernetes deployment / removes it.
  • A script that removes the produced docker containers, cleans it up.

With these scripts, you should be able to easier describe how to run the entire demo from start to finish. Note that it should be interactive, and the attendant should see things happening. That is why we also would like to inspect the logs, etc.

Note that you might need to set the portals core repo as a sub-repository in the vldb demo repository.

scripts/deployment/README.md Outdated Show resolved Hide resolved
scripts/deployment/Kubernetes/Deployment.yaml Outdated Show resolved Hide resolved
scripts/deployment/docker/Dockerfile-Server Outdated Show resolved Hide resolved
scripts/deployment/docker/Dockerfile-ShoppingCartClient Outdated Show resolved Hide resolved
scripts/deployment/docker/Dockerfile-Client Outdated Show resolved Hide resolved
@MKLepium MKLepium requested a review from jspenger July 17, 2023 20:39
scripts/deployment/README.md Outdated Show resolved Hide resolved
scripts/deployment/docker/Dockerfile-Server Show resolved Hide resolved
scripts/deployment/docker/Dockerfile-Client Outdated Show resolved Hide resolved
@jspenger jspenger merged commit fbbc109 into portals-project:main Aug 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants