Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added vldb-helper-script and tutorial for shoppingcart example #1

Merged
merged 5 commits into from
Aug 14, 2023

Conversation

MKLepium
Copy link
Contributor

"TODO: Explain Shopping Cart example itself"
I remember that you showed me an overview and an explanaion for the shopping cart example, but I can't find it right now.

@MKLepium MKLepium requested a review from jspenger July 25, 2023 20:27
@jspenger
Copy link
Member

The description of the demo scenario is in both the paper and the vldbdemoplanning repo. Ther e you can find the description. Make sure to run through the described scenario as it is in the text, and see that all steps as described are possible.

Copy link
Member

@jspenger jspenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments

In a different PR portals-project/portals#231 I gave a quick overview of what would be very useful features for the VLDB demo w.r.t. the Shopping Cart demo.

We should have some scripts that make it easy to run the VLDB demo. I suggest creating a sub-directory scenario1 in the vldb-demo repo: https://github.com/portals-project/vldb2023demo. Where these scripts are included, and should likely have the following:

  • A script that installs everything that is necessary.
  • A script that starts minikube and starts docker.
  • A script that launches the kubernetes deployment.
  • A script that, when started, starts observing the logs of the kubernetes deployment; so that we can inspect what is happening on the server.
  • A script that cleans up the kubernetes deployment / removes it.
  • A script that removes the produced docker containers, cleans it up.

With these scripts, you should be able to easier describe how to run the entire demo from start to finish. Note that it should be interactive, and the attendant should see things happening. That is why we also would like to inspect the logs, etc.

Tasks

From this list, and some additional things that come to mind, what is missing so far is the following, and what should be changed:

  • Creating a sub-directorty scenario1 in the vldb-demo repo where the scripts etc. are included. As per the discussion today, this should also include the application code, so that all example-relevant things are here. Similarly, it makes sense to have the corresponding docker and kubernetes files for this scenario here in this directory.
  • A script which builds the docker containers? I think this is still missing / or implicit.
  • A script which removes the built docker containers.
  • A script which starts observing the logs of the server. Currently, from what I can tell in the current version, the logs of the server are queried once and saved to a file? It would be better to simply connect to the server and inspects its log, through calling the kubectl logs command, this should be continuous, as the application runs continuously, and never stops. What I mean, in essence, is that the script should simply connect to the server and continously print its logs using kubeclt logs.
  • Additionally, as described during the standup today, the demo was intended to show how to incrementally start the application. So, instead, there should be commands for starting the application incrementally, in the order as described in the scenario description. It is essential that it is possible to submit an application from outside of the Kubernetes cluster, for a better demo experience.

@jspenger jspenger merged commit 0353100 into portals-project:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants