-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename browser state IndexedDB database names #4864
Labels
area: workbench
Issues related to Workbench category.
Milestone
Comments
29 tasks
sharon-wang
added a commit
that referenced
this issue
Oct 16, 2024
- Addresses: #4864 - updates the prefixes for web IndexedDB databases and stores to use `positron` instead of `vscode` - we don't delete the existing stores that are prefixed with `vscode` I've done some testing on a dev build of Server Web on Mac and a local release build of Positron on Workbench on Ubuntu 24. ### QA Notes - this change impacts Positron Web / Server Web only - the data stores are working if: - you're seeing the renamed databases and stores in Developer Tools > Application > Storage > IndexedDB - the layout state is being persisted when you close and reopen Positron in the same browser; for example: 1. Open up a folder in Positron Web / Server Web 2. Command Prompt > View: Toggle Zen Mode 3. Close the browser 4. Open up the same folder in the same browser in Positron Web / Server Web 5. You should still be in Zen Mode
Implemented in #5035 |
IndexDB now has positron prefix names |
isabelizimm
pushed a commit
that referenced
this issue
Oct 18, 2024
- Addresses: #4864 - updates the prefixes for web IndexedDB databases and stores to use `positron` instead of `vscode` - we don't delete the existing stores that are prefixed with `vscode` I've done some testing on a dev build of Server Web on Mac and a local release build of Positron on Workbench on Ubuntu 24. ### QA Notes - this change impacts Positron Web / Server Web only - the data stores are working if: - you're seeing the renamed databases and stores in Developer Tools > Application > Storage > IndexedDB - the layout state is being persisted when you close and reopen Positron in the same browser; for example: 1. Open up a folder in Positron Web / Server Web 2. Command Prompt > View: Toggle Zen Mode 3. Close the browser 4. Open up the same folder in the same browser in Positron Web / Server Web 5. You should still be in Zen Mode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Background
Positron saves browser state in several IndexedDBs, each named
vscode-web-{DB_NAME}
, which may result in unexpected behaviour if a user opens a folder in Positron and then later opens the same folder in VS Code, or vice versa.To avoid such collisions, we should rename positron's IndexedDBs, perhaps something like
positron-web-{DB_NAME}
.Possible Solution
In particular, we may want to rename
positron/src/vs/workbench/browser/web.main.ts
Line 466 in e51332d
to
positron-web-db
; andpositron/src/vs/workbench/services/storage/browser/storageService.ts
Line 342 in e51332d
to
positron-web-state-db
.There are other databases which have the prefix
vscode
that we may want to rename topositron
as well.Considerations
Currently, since our databases are the same name as VS Code, there may be some convenient state sharing that we would lose after renaming the databases to be specific to Positron. At the same time, not renaming the databases may result in unexpected behaviour due to the shared state.
The text was updated successfully, but these errors were encountered: