Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename indexed dbs with positron prefix #5035

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

sharon-wang
Copy link
Member

@sharon-wang sharon-wang commented Oct 15, 2024

I've done some testing on a dev build of Server Web on Mac and a local release build of Positron on Workbench on Ubuntu 24.

QA Notes

  • this change impacts Positron Web / Server Web only
  • the data stores are working if:
    • you're seeing the renamed databases and stores in Developer Tools > Application > Storage > IndexedDB
    • the layout state is being persisted when you close and reopen Positron in the same browser; for example:
      1. Open up a folder in Positron Web / Server Web
      2. Command Prompt > View: Toggle Zen Mode
      3. Close the browser
      4. Open up the same folder in the same browser in Positron Web / Server Web
      5. You should still be in Zen Mode

@sharon-wang sharon-wang merged commit 638de70 into main Oct 16, 2024
3 checks passed
@sharon-wang sharon-wang deleted the rename-indexed-dbs branch October 16, 2024 18:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants