Skip to content

Minor design tweaks for chat #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gregswinehart opened this issue Feb 14, 2025 · 0 comments · Fixed by #1861
Closed

Minor design tweaks for chat #1855

gregswinehart opened this issue Feb 14, 2025 · 0 comments · Fixed by #1861
Labels
needs-triage

Comments

@gregswinehart
Copy link
Collaborator

  1. I'd love it if the container for the conversation ended above the text input at the bottom... It's quite noticeable when the scroll bar goes below where it seems like it should next to the text input:
Image
  1. Also, I think the chat container could use some padding on the left and right, to 1. let it breathe and 2. to avoid the scroll bar smooshing up next to it (especially noticeable when next to a code box.) Maybe .75rem on the left and right? Maybe even 1rem?

Image
gadenbuie added a commit that referenced this issue Feb 20, 2025
@gadenbuie
fix(chat): Improve content/input overlap
1e674f4 
* Avoid overlap as much as possible
* Fix scroll bar positioning
* When input is floating, we add a `shadow` class

Fixes #1855
@gadenbuie gadenbuie mentioned this issue Feb 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(chat): Adjust scroll bar positioning posit-dev/py-shiny
1 participant
@gregswinehart