Skip to content

fix(chat): Adjust scroll bar positioning #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 24, 2025
Merged

Conversation

gadenbuie
Copy link
Collaborator

@gadenbuie gadenbuie commented Feb 20, 2025

Fixes #1855

  • Move scroll bar away from content
  • Don't overlap content and input...
  • Until input starts to float (because position: sticky) at which point we add a shadow
Kapture.2025-02-20.at.14.23.23.mp4

* Avoid overlap as much as possible
* Fix scroll bar positioning
* When input is floating, we add a `shadow` class

Fixes #1855
@gadenbuie gadenbuie marked this pull request as ready for review February 20, 2025 19:25
@cpsievert

This comment was marked as outdated.

@cpsievert

This comment was marked as outdated.

Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gadenbuie gadenbuie merged commit bc07d2c into main Feb 24, 2025
41 checks passed
@gadenbuie gadenbuie deleted the chat/fix-scrollbar-overlap branch February 24, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor design tweaks for chat
2 participants