Disable mergeScripts & mergeStyles in safe preset #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a case:
htmlnano's
mergeScripts
andmergeStyles
can't detect such a case and may cause unwanted behaviors by extracting and merging them to the top level.There are many ways for a developer to make their own template (E.g.
<script type="mySecretTemplate"><script>/* I shouldn't be executed when page is loaded! */</script></script>
) and there is no way for htmlnano can identify them all. Thus those two features should be disabled in v2 by default.Those two features can retain enabled by default in v1 since we haven't received any bug reports about the issue, yet.