Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable mergeScripts & mergeStyles in safe preset #170

Merged
merged 1 commit into from
Dec 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/presets/max.es6
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ export default { ...safePreset,
removeComments: 'all',
removeAttributeQuotes: true,
removeRedundantAttributes: true,
mergeScripts: true,
mergeStyles: true,
removeUnusedCss: {},
minifyCss: {
preset: 'default',
Expand Down
4 changes: 2 additions & 2 deletions lib/presets/safe.es6
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ export default {
collapseWhitespace: 'conservative',
custom: [],
deduplicateAttributeValues: true,
mergeScripts: true,
mergeStyles: true,
mergeScripts: false,
mergeStyles: false,
removeUnusedCss: false,
minifyCss: {
preset: 'default',
Expand Down
4 changes: 2 additions & 2 deletions test/modules/mergeScripts.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { init } from '../htmlnano';
import safePreset from '../../lib/presets/safe';
import maxPreset from '../../lib/presets/max';


describe('mergeScripts', () => {
const options = {
mergeScripts: safePreset.mergeScripts,
mergeScripts: maxPreset.mergeScripts,
};

it('should merge <script> with the same attributes', () => {
Expand Down
4 changes: 2 additions & 2 deletions test/modules/mergeStyles.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { init } from '../htmlnano';
import safePreset from '../../lib/presets/safe';
import maxPreset from '../../lib/presets/max';


describe('mergeStyles', () => {
const options = {
mergeStyles: safePreset.mergeStyles,
mergeStyles: maxPreset.mergeStyles,
};

it('should merge multiple <style> with the same "type" and "media" into one', () => {
Expand Down