Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit/integration tests #39

Merged
merged 5 commits into from
Apr 22, 2016
Merged

test: add unit/integration tests #39

merged 5 commits into from
Apr 22, 2016

Conversation

zacharygolba
Copy link
Contributor

@zacharygolba zacharygolba commented Apr 20, 2016

This PR implements Unit and Integrations tests with Travis-CI hooks to help us keep Lux stable.

Note:

This does not give us 100% test coverage but provides a solid foundation for tests to be run and written before we merge anything into master.

Closes #8

chore: add ci config and test fixtures

fix: hard-coded environment property in Base unit test

fix: tests timeout on ci server

fix: wrong build task for tests in gulpfile

fix: add stdout and stderr listeners to debug test on ci server

fix: shebang line not finding node on linux (#32)

chore: bump lux up to the latest release in the test-app

fix: increase sleep interval before running tests

fix: increase sleep interval again

fix: decrease sleep interval and stop testing node 4.x for now

fix: listening message dispatched before workers are ready (#34)

chore: Link to Medium Article in Readme (#33)

feat: add pagination to controller integration test

fix: sql dump syntax error

fix: wrong sql dump :P

feat: test against node 4 as well as 5

fix: increase mocha timeout time

Node 4 works locally just takes longer to boot.

feat: more integration testing

fix: logger date incorrect (#35)

Merge pull request #36 from postlight/database-missing-port

fix: missing port in database config generation

chore: bump version to 0.0.1-beta.3 (#37)

chore: add travis badge to readme
@@ -1,4 +1,4 @@
# Lux
# Lux [![Build Status](https://travis-ci.org/postlight/lux.svg?branch=master)](https://travis-ci.org/postlight/lux)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update the Testing section with details.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also be cool to add the badges via Shields.io. You could also get the nifty NPM badges if you wanted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I'll make the changes this evening.

@mutewinter
Copy link

Needs a small update for the README.md as mentioned above.

@zacharygolba zacharygolba self-assigned this Apr 21, 2016
@zacharygolba
Copy link
Contributor Author

zacharygolba commented Apr 21, 2016

@mutewinter NPM badge and Shields.io implementation can be done in another PR. #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants