Do not allow switches with the same node or bus at both ends.

[marqueslanauja]

Signed-off-by: José Antonio Marqués marquesja@aia.es

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
Switches with the same node or bus at both ends are allowed.

What is the new behavior (if this is a feature change)?
An exception is thrown when a switch with the same node or bus at both ends is added.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

• The Breaking Change or Deprecated label has been added
• The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

[miovd]

Could you please add something clever (no idea right now) to handle compatibility with old XIIDM files that can allow this configuration?

[marqueslanauja]

We decided to handle compatibility with old XIIDM files by discarding switches with the same node or bus. This verification is always done independently of the XIIDM version.
Another alternative is to add a new attribute in the SwitchAdder to configure the check, throw an exception (by default) or discard the switch (when importing XIIDM files). We selected the first alternative to avoid adding new attributes in the adder.

[miovd]

Hello @marqueslanauja @zamarrenolm I made some modifications to add to your work:

• check that the identifiable is not null before reading sub-elements to prevent NPE
• discard switches with same ends during writing (for example while writing a calculated view) to allow round trip

Do you agree? If yes, it is good for me!

[marqueslanauja]

Hello @marqueslanauja @zamarrenolm I made some modifications to add to your work:

• check that the identifiable is not null before reading sub-elements to prevent NPE
• discard switches with same ends during writing (for example while writing a calculated view) to allow round trip

Do you agree? If yes, it is good for me!

It is ok for me. Thanks.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

81.4% Coverage
0.0% Duplication