Do not allow switches with the same node or bus at both ends.

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/BusBreakerVoltageLevel.java

@@ -91,6 +91,9 @@ public Switch add() {
             if (busId2 == null) {
                 throw new ValidationException(this, "second connection bus is not set");
             }
+            if (busId1.equals(busId2)) {
+                throw new ValidationException(this, "same bus at both ends");
+            }
 
             SwitchImpl aSwitch = new SwitchImpl(BusBreakerVoltageLevel.this, id, getName(), isFictitious(), SwitchKind.BREAKER, open, true);
             addSwitch(aSwitch, busId1, busId2);

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NodeBreakerVoltageLevel.java

@@ -151,6 +151,9 @@ public Switch add() {
             if (node2 == null) {
                 throw new ValidationException(this, "second connection node is not set");
             }
+            if (node1.equals(node2)) {
+                throw new ValidationException(this, "same node at both ends");
+            }
             if (kind == null) {
                 throw new ValidationException(this, "kind is not set");
             }

iidm/iidm-impl/src/test/java/com/powsybl/iidm/network/impl/tck/SwitchBusBreakerTest.java

@@ -0,0 +1,11 @@
+/**
+ * Copyright (c) 2022, RTE (http://www.rte-france.com)
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+package com.powsybl.iidm.network.impl.tck;
+
+import com.powsybl.iidm.network.tck.AbstractSwitchBusBreakerTest;
+
+public class SwitchBusBreakerTest extends AbstractSwitchBusBreakerTest { }

iidm/iidm-impl/src/test/java/com/powsybl/iidm/network/impl/tck/SwitchNodeBreakerTest.java

@@ -0,0 +1,11 @@
+/**
+ * Copyright (c) 2022, RTE (http://www.rte-france.com)
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+package com.powsybl.iidm.network.impl.tck;
+
+import com.powsybl.iidm.network.tck.AbstractSwitchNodeBreakerTest;
+
+public class SwitchNodeBreakerTest extends AbstractSwitchNodeBreakerTest { }

iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractSwitchBusBreakerTest.java

@@ -0,0 +1,41 @@
+/**
+ * Copyright (c) 2022, RTE (http://www.rte-france.com)
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+package com.powsybl.iidm.network.tck;
+
+import com.powsybl.iidm.network.*;
+import com.powsybl.iidm.network.test.BatteryNetworkFactory;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+public abstract class AbstractSwitchBusBreakerTest {
+
+    @Rule
+    public ExpectedException thrown = ExpectedException.none();
+
+    private Network network;
+    private VoltageLevel voltageLevel;
+
+    @Before
+    public void initNetwork() {
+        network = BatteryNetworkFactory.create();
+        voltageLevel = network.getVoltageLevel("VLGEN");
+    }
+
+    @Test
+    public void addSwitchWithSameBusAtBothEnds() {
+        thrown.expect(ValidationException.class);
+        thrown.expectMessage("Switch 'Sw1': same bus at both ends");
+        Bus bus = voltageLevel.getBusBreakerView().getBus("NGEN");
+        voltageLevel.getBusBreakerView().newSwitch()
+            .setId("Sw1")
+            .setBus1(bus.getId())
+            .setBus2(bus.getId())
+            .add();
+    }
+}

iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/AbstractSwitchNodeBreakerTest.java

@@ -0,0 +1,55 @@
+/**
+ * Copyright (c) 2022, RTE (http://www.rte-france.com)
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+package com.powsybl.iidm.network.tck;
+
+import com.powsybl.iidm.network.*;
+import com.powsybl.iidm.network.test.FictitiousSwitchFactory;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+public abstract class AbstractSwitchNodeBreakerTest {
+
+    @Rule
+    public ExpectedException thrown = ExpectedException.none();
+
+    private Network network;
+    private VoltageLevel voltageLevel;
+
+    @Before
+    public void initNetwork() {
+        network = FictitiousSwitchFactory.create();
+        voltageLevel = network.getVoltageLevel("C");
+    }
+
+    @Test
+    public void addSwitchWithSameNodeAtBothEnds() {
+        thrown.expect(ValidationException.class);
+        thrown.expectMessage("Switch 'Sw1': same node at both ends");
+        int newNode = voltageLevel.getNodeBreakerView().getMaximumNodeIndex() + 1;
+        voltageLevel.getNodeBreakerView().newSwitch()
+            .setId("Sw1")
+            .setNode1(newNode)
+            .setNode2(newNode)
+            .setKind(SwitchKind.BREAKER)
+            .add();
+    }
+
+    @Test
+    public void addSwitchWithNullKind() {
+        thrown.expect(ValidationException.class);
+        thrown.expectMessage("Switch 'Sw1': kind is not set");
+        int newNode1 = voltageLevel.getNodeBreakerView().getMaximumNodeIndex() + 1;
+        int newNode2 = newNode1 + 1;
+        voltageLevel.getNodeBreakerView().newSwitch()
+            .setId("Sw1")
+            .setNode1(newNode1)
+            .setNode2(newNode2)
+            .add();
+    }
+}