Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all the things [WIP] #2124

Closed
wants to merge 1 commit into from
Closed

Update all the things [WIP] #2124

wants to merge 1 commit into from

Conversation

jonenst
Copy link
Contributor

@jonenst jonenst commented May 17, 2022

Signed-off-by: HARPER Jon jon.harper87@gmail.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
NO

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
outdated libs

What is the new behavior (if this is a feature change)?
up to date libs

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
NO

Other information:
Problem with rdf4j posted on their chat: https://gitter.im/eclipse/rdf4j
Looking at the code Looking at the code eclipse-rdf4j/rdf4j@31eae61980b#diff-316111ad63bae0052ae1214d4e3abff22b8f951323f25287e24be2af0205e81eR336 is there a way to avoid calling ValidatingValueFactory which throws on whitespace ?

univocity has changed their API, maybe we can get them to revert ? uniVocity/univocity-parsers#427 (comment)

Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
@jonenst jonenst requested review from flo-dup and geofjamg May 17, 2022 16:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jonenst
Copy link
Contributor Author

jonenst commented May 25, 2022

eclipse-rdf4j/rdf4j#3917
"
By the way you can bypass the behavior by using the SimpleValueFactory instead of the one supplied by the connection:
SimpleValueFactory.getInstance().createIRI(namespace, localName);
"
if we don't want to wait for the release we can just update to use the previous snippet .

@annetill
Copy link
Member

Solved by #2704

@annetill annetill closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants