Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade2023 notall2 #2704

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Upgrade2023 notall2 #2704

merged 5 commits into from
Sep 18, 2023

Conversation

jonenst
Copy link
Contributor

@jonenst jonenst commented Sep 18, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
NO

What kind of change does this PR introduce?
Upgrade all the depdencies

What is the current behavior?
old runtime deps

What is the new behavior (if this is a feature change)?
recent runtime deps

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)
    Biggest change is the groovy package migration ?

Other information:
see #2702
Same but rdf4j and univocity are not upgraded

@jonenst
Upgrade all runtime dependencies to the most recent version
8a1c767 
The following remains and is left as is (I did a manual check that there was nothing better available)

$ mvn versions:display-dependency-updates
[INFO]   com.google.code.findbugs:annotations ................ 3.0.1 -> 3.0.1u2
[INFO]   com.powsybl:powsybl-build-tools ............................. 13 -> 14
[INFO]   org.apache.groovy:groovy ..................... 4.0.14 -> 5.0.0-alpha-2
[INFO]   org.apache.groovy:groovy-console ............. 4.0.14 -> 5.0.0-alpha-2
[INFO]   org.apache.groovy:groovy-groovysh ............ 4.0.14 -> 5.0.0-alpha-2
[INFO]   org.apache.groovy:groovy-nio ................. 4.0.14 -> 5.0.0-alpha-2
[INFO]   org.apache.maven:maven-core ................... 3.8.5 -> 4.0.0-alpha-7
[INFO]   org.eclipse.rdf4j:rdf4j-common-transaction ......... 4.3.6 -> 5.0.0-M1
[INFO]   org.eclipse.rdf4j:rdf4j-repository-sail ............ 4.3.6 -> 5.0.0-M1
[INFO]   org.eclipse.rdf4j:rdf4j-rio-rdfxml ................. 4.3.6 -> 5.0.0-M1
[INFO]   org.eclipse.rdf4j:rdf4j-sail-memory ................ 4.3.6 -> 5.0.0-M1

TODO: there's at least one relocation I know of that I didn't handle: findbugs -> spotbugs
TODO: are there other relocations ?

Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
@jonenst
revert rdf4j and univocity versions
9d48d11 
RDF4J caused a performance regression (70s -> 130s) on a big cgmes file
Univocity needs a weird code adaptation around enums conversions

Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
@jonenst jonenst requested a review from geofjamg September 18, 2023 09:53
@jonenst jonenst mentioned this pull request Sep 18, 2023
Closed
5 tasks
@zamarrenolm
Copy link
Member

I've checked that the performance degradation of RDF4J was introduced in 4.3.3.

I've used version 4.3.2 successfully with all CGMES conversion unit tests and with similar performance to the old version we were using (4.2.2).

@jonenst
Copy link
Contributor Author

jonenst commented Sep 18, 2023 •
edited
Loading

I've checked that the performance degradation of RDF4J was introduced in 4.3.3.

good to know. Then probably we'll upgrade to 4.2.2 -> 4.3.2 in this PR, is that what you suggested ?

@zamarrenolm
Copy link
Member

I've checked that the performance degradation of RDF4J was introduced in 4.3.3.

good to know. Then probably we'll upgrade to 4.2.2 -> 4.3.2 in this PR, is that what you suggested ?

Yes, that is my proposal

@geofjamg
Copy link
Member

geofjamg commented Sep 18, 2023 •
edited
Loading

I've checked that the performance degradation of RDF4J was introduced in 4.3.3.

I've used version 4.3.2 successfully with all CGMES conversion unit tests and with similar performance to the old version we were using (4.2.2).

We should build a test case showing the performance regression and submit it to RDF4J team

@geofjamg geofjamg merged commit 32e65e0 into main Sep 18, 2023
5 checks passed
@geofjamg geofjamg deleted the upgrade2023_notall2 branch September 18, 2023 12:42
This was referenced Sep 19, 2023
Closed
Closed
@rolnico rolnico mentioned this pull request May 15, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geofjamg geofjamg Awaiting requested review from geofjamg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonenst @zamarrenolm @geofjamg