Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another dependencies update #3018

Merged
merged 10 commits into from
Jun 17, 2024
Merged

Another dependencies update #3018

merged 10 commits into from
Jun 17, 2024

Conversation

rolnico
Copy link
Member

@rolnico rolnico commented May 15, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Dependencies update

What is the current behavior?
Old dependencies versions

What is the new behavior (if this is a feature change)?
New dependency versions:

Library / component Previous version New version
assertj 3.25.3 3.26.0
commons-cli 1.5.0 1.8.0
commons-compress 1.26.0 1.26.2
commons-text 1.10.0 1.12.0
groovy 4.0.14 4.0.21
guava 33.1.0-jre 33.2.1-jre
jackson 2.17.0 2.17.1
maven-plugin-annotations 3.9.0 3.13.0
mockito 5.11.0 5.12.0
native-lib-loader 2.4.0 2.5.0
poi-ooxml 5.2.3 5.2.5
testcontainers 1.19.7 1.19.8
threeten-extra 1.7.2 1.8.0
zstd-jni 1.5.5-5 1.5.6-3

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Other information:
A few dependencies cannot be directly updated:

  • trove4j is now abandoned
  • univocity-parsers is now abandoned
  • annotations has changed its groupId but is called by graphviz which seems abandoned

We will have to work on those in separate PRs

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@rolnico rolnico self-assigned this May 15, 2024
@rolnico
Copy link
Member Author

rolnico commented May 15, 2024

@zamarrenolm I updated rdf4j to the new 4.3.11 version, could you compare the performances to see if the performance issue @jonenst saw in #2704 is solved ?

Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
@zamarrenolm
Copy link
Member

@zamarrenolm I updated rdf4j to the new 4.3.11 version, could you compare the performances to see if the performance issue @jonenst saw in #2704 is solved ?

I've detected a relevant increase in time when running CGMES unit tests. In my laptop: 2 minutes using main branch (rdf4j 4.3.2) and 3 minutes using rdf4j 4.3.11. I am analysing it in more detail. Will keep you posted.

@zamarrenolm
Copy link
Member

For RDF4J, I tried to analyse the performance in detail, using the "query explanation" mechanism provided by the library, then I ran into contradictory information.

The "query explanation" says the run time for the queries are more or less the same for 4.3.2 and 4.3.11 (even a little bit better for the new version), but when you "evaluate" the actual query (not inside the "query explanation"), the measured time is much worse for 4.3.11. The "query explanation" run states that fully evaluate the query and iterate over all the result sets, so one would expect similar results of timed "query explanations" and actual "evaluation" of a query.

rolnico added 5 commits June 3, 2024 09:45
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Signed-off-by: Nicolas Rol <nicolas.rol@rte-france.com>
Copy link

@olperr1 olperr1 merged commit fd3ce3e into main Jun 17, 2024
7 checks passed
@olperr1 olperr1 deleted the nro/upgrade_dependencies branch June 17, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants