CGMES : import optional ratedS value of transformers #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luma <zamarrenolm@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
marqueslanauja
approved these changes
Jul 13, 2023
Signed-off-by: José Antonio Marqués <marquesja@aia.es>
annetill
approved these changes
Sep 11, 2023
|
Kudos, SonarCloud Quality Gate passed! |
annetill
reviewed
Oct 4, 2023
| @@ -66,6 +66,7 @@ static class InterpretedWinding { | |||
| final TapChangerConversion.InterpretedEnd end1; | |||
| final InterpretedEnd2 end2; | |||
| final boolean structuralRatioAtEnd2; | |||
| final double ratedS; | |||
There was a problem hiding this comment.
@zamarrenolm we have a regression here because of this double instead of Double. I am going to open a PR for this bug fix and it will lead to a patch release of core.
zamarrenolm
added a commit
that referenced
this pull request
Oct 4, 2023
Signed-off-by: Luma <zamarrenolm@aia.es>
5 tasks
annetill
pushed a commit
that referenced
this pull request
Oct 4, 2023
olperr1
pushed a commit
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
CGMES attribute
ratedSof transformer ends is not read.What is the new behavior (if this is a feature change)?
CGMES attribute
ratedSof transformer is read and saved in the IIDM model.The attribute is optional in CGMES.
CGMES specifies that for 2-winding transformers the values for the high and low voltage sides shall be identical.
Does this PR introduce a breaking change or deprecate an API?
Other information: