Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression introduced in #2648 (optional ratedS for 3-winding transformers) #2733

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Fix regression introduced in #2648 (optional ratedS for 3-winding transformers) #2733

merged 2 commits into from
Oct 4, 2023

Conversation

zamarrenolm
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes regression that was provoked in #2648

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

@zamarrenolm
Fix regression introduced in #2648
58869be 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm zamarrenolm self-assigned this Oct 4, 2023
@zamarrenolm zamarrenolm requested a review from annetill October 4, 2023 08:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@annetill annetill merged commit 64c80de into main Oct 4, 2023
6 checks passed
@annetill annetill deleted the cgmes_fix_regression_rateds_3wt branch October 4, 2023 16:13
olperr1 pushed a commit that referenced this pull request Oct 6, 2023
@zamarrenolm @olperr1
Fix optional ratedS regression introduced in #2648 (#2733)
e388593 
Signed-off-by: Luma <zamarrenolm@aia.es>
(cherry picked from commit 64c80de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annetill annetill annetill approved these changes

Assignees

@zamarrenolm zamarrenolm

Labels
bug CGMES PR: next-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zamarrenolm @annetill