Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary iidm #2853

Merged
merged 48 commits into from
Jan 16, 2024
Merged

Binary iidm #2853

merged 48 commits into from
Jan 16, 2024

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Jan 15, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
Fixes #894

What kind of change does this PR introduce?
Feature

What is the new behavior (if this is a feature change)?
Network can be exported in binary format

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

flo-dup added 30 commits January 8, 2024 11:25
@flo-dup
Remove ifs prior to calling writeStringAttribute
cc4470b 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Remove ifs prior to calling writeDoubleAttribute
a373903 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Remove ifs prior to calling writeIntAttribute
f1a14ac 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Remove ifs prior to calling writeStringArrayAttribute
a6ca855 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix int
b755d4a 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix writeIntArrayAttribute for empty collections
7602111 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix writeString
18dcea2 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Remove if prior to calling writeEnumAttribute
dd6aacf 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Remove if prior to calling writeBooleanAttribute
443496d 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add write methods with boxed Double & Boolean
ef2c7e3 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
First version of BinReader
4775389 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
First version of BinWriter
16e8954 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
fix
7b70512 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix reader & writer
2ad5ab1 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add TreeDataFormat.BIN
cc41ee7 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Writing fixes
7d2249d 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Reading fixes
258bfdd 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
First passing unit test V_V
8b55683 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix referenceTerminal ser/de for the corner case null slack
cc81b7c 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix referenceTerminal ser/de for the corner case null slack
643dd2d 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Simplify optional writing
14d362a 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add readOptionalIntAttribute
841227c 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add readOptionalDoubleAttribute
59249de 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add readOptionalBooleanAttribute
1d7ba1d 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Remove unused imports
0f51e41 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fixes
1989c66 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Use optionals when reading optional values
c843f29 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Read with UTF8
9d59633 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Buffered streams
d14b3ea 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix
53f2628 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup requested a review from geofjamg January 15, 2024 14:16
@flo-dup flo-dup self-assigned this Jan 15, 2024
@flo-dup
Use inputStream::readNBytes instead of inputStream::read
45551dc 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Merge branch 'main' into binary
8e6a3d4 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add exporter/importer
b8b7838 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup and others added 13 commits January 15, 2024 16:26
@flo-dup
Introduce TreeDataHeader
33e1d2a 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Update & move unit test references from V1_11 to V1_12
80c02d0 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@geofjamg
Merge branch 'main' into binary
dd10abf
@flo-dup
fix
0c59947 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix regex for BinaryImporter
4cfc263 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Merge branch 'main' into binary
84c2e20 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix serialization/deserialization bugs
77d5ca0 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add binary transformation in all formats round trip
644fffc 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add magic number at file start
73a2915 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Add log about the feature being in beta state
9fd79cb 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Remove unused method
37c23ce 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Merge branch 'main' into binary
90a5b98 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Fix the 4 code smells and then the consecutive duplicate
1b0ce29 
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
90.2% Coverage on New Code
0.8% Duplication on New Code

See analysis details on SonarCloud

@flo-dup flo-dup merged commit 68f3298 into main Jan 16, 2024
6 checks passed
@flo-dup flo-dup deleted the binary branch January 16, 2024 16:13
@flo-dup flo-dup added the Breaking Change API is broken label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geofjamg geofjamg geofjamg approved these changes

Assignees

@flo-dup flo-dup

Labels
Beta feature Breaking Change API is broken January release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binary network format for efficient exchanges (Apache AVRO, protobuf ...)
2 participants
@flo-dup @geofjamg