Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary iidm #2853

Merged
merged 48 commits into from
Jan 16, 2024
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
cc4470b
Remove ifs prior to calling writeStringAttribute
flo-dup Jan 8, 2024
a373903
Remove ifs prior to calling writeDoubleAttribute
flo-dup Jan 8, 2024
f1a14ac
Remove ifs prior to calling writeIntAttribute
flo-dup Jan 8, 2024
a6ca855
Remove ifs prior to calling writeStringArrayAttribute
flo-dup Jan 8, 2024
b755d4a
Fix int
flo-dup Jan 8, 2024
7602111
Fix writeIntArrayAttribute for empty collections
flo-dup Jan 8, 2024
18dcea2
Fix writeString
flo-dup Jan 8, 2024
dd6aacf
Remove if prior to calling writeEnumAttribute
flo-dup Jan 8, 2024
443496d
Remove if prior to calling writeBooleanAttribute
flo-dup Jan 8, 2024
ef2c7e3
Add write methods with boxed Double & Boolean
flo-dup Jan 9, 2024
4775389
First version of BinReader
flo-dup Jan 9, 2024
16e8954
First version of BinWriter
flo-dup Jan 9, 2024
7b70512
fix
flo-dup Jan 9, 2024
2ad5ab1
Fix reader & writer
flo-dup Jan 10, 2024
cc41ee7
Add TreeDataFormat.BIN
flo-dup Jan 10, 2024
7d2249d
Writing fixes
flo-dup Jan 10, 2024
258bfdd
Reading fixes
flo-dup Jan 10, 2024
8b55683
First passing unit test V_V
flo-dup Jan 10, 2024
cc81b7c
Fix referenceTerminal ser/de for the corner case null slack
flo-dup Jan 10, 2024
643dd2d
Fix referenceTerminal ser/de for the corner case null slack
flo-dup Jan 10, 2024
14d362a
Simplify optional writing
flo-dup Jan 10, 2024
841227c
Add readOptionalIntAttribute
flo-dup Jan 10, 2024
59249de
Add readOptionalDoubleAttribute
flo-dup Jan 10, 2024
1d7ba1d
Add readOptionalBooleanAttribute
flo-dup Jan 10, 2024
0f51e41
Remove unused imports
flo-dup Jan 10, 2024
1989c66
Fixes
flo-dup Jan 10, 2024
c843f29
Use optionals when reading optional values
flo-dup Jan 10, 2024
9d59633
Read with UTF8
flo-dup Jan 10, 2024
d14b3ea
Buffered streams
flo-dup Jan 11, 2024
53f2628
Fix
flo-dup Jan 15, 2024
45551dc
Use inputStream::readNBytes instead of inputStream::read
flo-dup Jan 15, 2024
8e6a3d4
Merge branch 'main' into binary
flo-dup Jan 15, 2024
b8b7838
Add exporter/importer
flo-dup Jan 15, 2024
33e1d2a
Introduce TreeDataHeader
flo-dup Jan 15, 2024
80c02d0
Update & move unit test references from V1_11 to V1_12
flo-dup Jan 15, 2024
dd10abf
Merge branch 'main' into binary
geofjamg Jan 15, 2024
0c59947
fix
flo-dup Jan 15, 2024
4cfc263
Fix regex for BinaryImporter
flo-dup Jan 15, 2024
84c2e20
Merge branch 'main' into binary
flo-dup Jan 15, 2024
77d5ca0
Fix serialization/deserialization bugs
flo-dup Jan 16, 2024
644fffc
Add binary transformation in all formats round trip
flo-dup Jan 16, 2024
73a2915
Add magic number at file start
flo-dup Jan 16, 2024
9fd79cb
Add log about the feature being in beta state
flo-dup Jan 16, 2024
37c23ce
Remove unused method
flo-dup Jan 16, 2024
90a5b98
Merge branch 'main' into binary
flo-dup Jan 16, 2024
1b0ce29
Fix the 4 code smells and then the consecutive duplicate
flo-dup Jan 16, 2024
1ce284d
Merge branch 'main' into binary
flo-dup Jan 16, 2024
f384e48
Merge branch 'main' into binary
flo-dup Jan 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused method
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup committed Jan 16, 2024

Verified

This commit was signed with the committer’s verified signature.
DavideD Davide D'Alto
commit 37c23ce5b81e9dd45029e5963d9b2c6b3c8975ab
Original file line number Diff line number Diff line change
@@ -95,13 +95,6 @@ protected DanglingLineAdder createAdder(VoltageLevel parent) {
return parent.newDanglingLine();
}

static boolean hasValidGeneration(DanglingLine dl, NetworkSerializerContext context) {
if (dl.getGeneration() != null) {
return context.getVersion().compareTo(IidmVersion.V_1_3) > 0;
}
return false;
}

@Override
protected void writeSubElements(DanglingLine dl, VoltageLevel vl, NetworkSerializerContext context) {
if (dl.getGeneration() != null) {