Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secondary voltage control notifications #2859

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Fix secondary voltage control notifications #2859

merged 2 commits into from
Jan 19, 2024

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Jan 18, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

We do not have enough information in secondary voltage notifications.

What is the new behavior (if this is a feature change)?
We can now known what is the control zone name and control unit emitting the notification

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

It changes the content of the notifications introduced by #2852, but this latter isn't yet released.

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg geofjamg requested a review from olperr1 January 18, 2024 15:27
Copy link

@annetill annetill merged commit 562af02 into main Jan 19, 2024
6 checks passed
@annetill annetill deleted the fix_svc_notif branch January 19, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants