Fix secondary voltage control notifications

iidm/iidm-extensions/src/main/java/com/powsybl/iidm/network/extensions/ControlUnit.java

@@ -12,6 +12,9 @@
  */
 public interface ControlUnit {
 
+    record ParticipateEvent(String controlZoneName, String controlUnitId, boolean value) {
+    }
+
     String getId();
 
     boolean isParticipate();

iidm/iidm-extensions/src/main/java/com/powsybl/iidm/network/extensions/PilotPoint.java

@@ -14,6 +14,9 @@
  */
 public interface PilotPoint {
 
+    record TargetVoltageEvent(String controlZoneName, double value) {
+    }
+
     /**
      * Get pilot point busbar section ID or bus ID of the bus/breaker view.
      */

iidm/iidm-extensions/src/main/java/com/powsybl/iidm/network/extensions/SecondaryVoltageControl.java

@@ -11,6 +11,7 @@
 import com.powsybl.iidm.network.Network;
 
 import java.util.List;
+import java.util.Optional;
 
 /**
  * @author Geoffroy Jamgotchian {@literal <geoffroy.jamgotchian at rte-france.com>}
@@ -21,6 +22,8 @@ public interface SecondaryVoltageControl extends Extension<Network> {
 
     List<ControlZone> getControlZones();
 
+    Optional<ControlZone> getControlZone(String name);
+
     @Override
     default String getName() {
         return NAME;

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/extensions/ControlUnitImpl.java

@@ -48,7 +48,8 @@ public void setParticipate(boolean participate) {
             this.participate = participate;
             SecondaryVoltageControlImpl secondaryVoltageControl = controlZone.getSecondaryVoltageControl();
             NetworkImpl network = (NetworkImpl) secondaryVoltageControl.getExtendable();
-            network.getListeners().notifyExtensionUpdate(secondaryVoltageControl, "controlUnitParticipate", !this.participate, this.participate);
+            network.getListeners().notifyExtensionUpdate(secondaryVoltageControl, "controlUnitParticipate",
+                    new ParticipateEvent(controlZone.getName(), id, !this.participate), new ParticipateEvent(controlZone.getName(), id, this.participate));
         }
     }
 }

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/extensions/PilotPointImpl.java

@@ -58,7 +58,8 @@ public void setTargetV(double targetV) {
             this.targetV = targetV;
             SecondaryVoltageControlImpl secondaryVoltageControl = controlZone.getSecondaryVoltageControl();
             NetworkImpl network = (NetworkImpl) secondaryVoltageControl.getExtendable();
-            network.getListeners().notifyExtensionUpdate(secondaryVoltageControl, "pilotPointTargetV", oldTargetV, targetV);
+            network.getListeners().notifyExtensionUpdate(secondaryVoltageControl, "pilotPointTargetV",
+                    new TargetVoltageEvent(controlZone.getName(), oldTargetV), new TargetVoltageEvent(controlZone.getName(), targetV));
         }
     }
 }

iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/extensions/SecondaryVoltageControlImpl.java

@@ -15,6 +15,7 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Objects;
+import java.util.Optional;
 
 /**
  * @author Geoffroy Jamgotchian {@literal <geoffroy.jamgotchian at rte-france.com>}
@@ -32,4 +33,10 @@ public class SecondaryVoltageControlImpl extends AbstractExtension<Network> impl
     public List<ControlZone> getControlZones() {
         return Collections.unmodifiableList(controlZones);
     }
+
+    @Override
+    public Optional<ControlZone> getControlZone(String name) {
+        Objects.requireNonNull(name);
+        return controlZones.stream().filter(z -> z.getName().equals(name)).findFirst();
+    }
 }

iidm/iidm-tck/src/test/java/com/powsybl/iidm/network/tck/extensions/AbstractSecondaryVoltageControlTest.java

@@ -11,10 +11,7 @@
 import com.powsybl.iidm.network.DefaultNetworkListener;
 import com.powsybl.iidm.network.Identifiable;
 import com.powsybl.iidm.network.Network;
-import com.powsybl.iidm.network.extensions.ControlUnit;
-import com.powsybl.iidm.network.extensions.ControlZone;
-import com.powsybl.iidm.network.extensions.SecondaryVoltageControl;
-import com.powsybl.iidm.network.extensions.SecondaryVoltageControlAdder;
+import com.powsybl.iidm.network.extensions.*;
 import com.powsybl.iidm.network.test.EurostagTutorialExample1Factory;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
@@ -57,6 +54,7 @@ public void setUp() {
     @Test
     void test() throws IOException {
         assertEquals(1, control.getControlZones().size());
+        assertTrue(control.getControlZone("z1").isPresent());
         ControlZone z1 = control.getControlZones().get(0);
         assertEquals("z1", z1.getName());
         assertNotNull(z1.getPilotPoint());
@@ -79,8 +77,8 @@ void pilotPointTargetVoltageNotificationTest() {
             public void onExtensionUpdate(Extension<?> extendable, String attribute, Object oldValue, Object newValue) {
                 assertInstanceOf(SecondaryVoltageControl.class, extendable);
                 assertEquals("pilotPointTargetV", attribute);
-                assertEquals(15d, (double) oldValue, 0d);
-                assertEquals(16d, (double) newValue, 0d);
+                assertEquals(new PilotPoint.TargetVoltageEvent("z1", 15d), oldValue);
+                assertEquals(new PilotPoint.TargetVoltageEvent("z1", 16d), newValue);
                 updated[0] = true;
             }
         });
@@ -98,8 +96,8 @@ void controlUnitParticipateNotificationTest() {
             public void onExtensionUpdate(Extension<?> extendable, String attribute, Object oldValue, Object newValue) {
                 assertInstanceOf(SecondaryVoltageControl.class, extendable);
                 assertEquals("controlUnitParticipate", attribute);
-                assertFalse((boolean) oldValue);
-                assertTrue((boolean) newValue);
+                assertEquals(new ControlUnit.ParticipateEvent("z1", "GEN", false), oldValue);
+                assertEquals(new ControlUnit.ParticipateEvent("z1", "GEN", true), newValue);
                 updated[0] = true;
             }
         });