LoadScalable: Do not apply constant power factor if P0 is zero #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmouradian
changed the title
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
vmouradian
force-pushed
the
scaling-loads-P0-is-zero
branch
from
02d785e to
3ce07ab
Compare
|
jeandemanged
changed the title
jeandemanged
approved these changes
Feb 9, 2024
colinepiloquet
approved these changes
Feb 12, 2024
m-guibert
approved these changes
Feb 12, 2024
olperr1
pushed a commit
that referenced
this pull request
Feb 15, 2024
Signed-off-by: vmouradian <valentin.mouradian@artelys.com> (cherry picked from commit c82fcdd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix (handle the case when Scaling a load with P0=0 and constantPowerFactor = true).
What is the current behavior?
The calculated new Q0 value will be NaN because of dividing by P0=0. Which will make setQ0() throw an error.
What is the new behavior (if this is a feature change)?
The value of Q0 is not updated ant stays as is, instead of throwing an error.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: