Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 85 update powsybl dependencies #89

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Issue 85 update powsybl dependencies #89

merged 2 commits into from
Feb 5, 2024

Conversation

tadam50
Copy link
Contributor

@tadam50 tadam50 commented Jan 22, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
'Fixes #85'

@tadam50 tadam50 requested a review from So-Fras January 22, 2024 14:56
@tadam50
Set to 2023.4.0
a56459a 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50
Fix compilation issues (see issue #86)
3cd183c 
Signed-off-by: Thomas ADAM <tadam@silicom.fr>
@tadam50 tadam50 force-pushed the issue_85_update_powsybl-dependencies branch from 3a8bd6d to 3cd183c Compare January 22, 2024 15:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tadam50 tadam50 self-assigned this Jan 22, 2024
flo-dup
flo-dup approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@flo-dup flo-dup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This highlights the problem of not supporting PositionVoltageLevelLayout parameters (feederStacked, removeUnnecessaryFictitiousNodes, ...) but it is handled in another PR

@flo-dup flo-dup merged commit 15dbae6 into main Feb 5, 2024
4 checks passed
@flo-dup flo-dup deleted the issue_85_update_powsybl-dependencies branch February 5, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo-dup flo-dup flo-dup approved these changes

@So-Fras So-Fras Awaiting requested review from So-Fras

Assignees

@tadam50 tadam50

Labels
PR: waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to powsybl-dependencies 2023.4.0
2 participants
@tadam50 @flo-dup