Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PassThroughInputManager needs to receive initial state from parent #1672

Closed
smoogipoo opened this issue Jun 29, 2018 · 0 comments · Fixed by #1682
Closed

PassThroughInputManager needs to receive initial state from parent #1672

smoogipoo opened this issue Jun 29, 2018 · 0 comments · Fixed by #1682

Comments

@smoogipoo
Copy link
Contributor

smoogipoo commented Jun 29, 2018

In the case that UseParentInput is set to true, it may not apply the full parent state when handling input.

E.g.

  1. Enter a mania beatmap without auto.
  2. Hold ctrl while in PlayerLoader just before gameplay.
  3. Attempt to press Ctrl+(-/+)

Expected: The scroll speed should change.
Actual: Because modifier keys specifically are not propagated on repeat, the mania input manager will handle a -/+ keypress without state.Keyboard.ControlPressed being true.

@smoogipoo smoogipoo added this to the July 2018 milestone Jun 29, 2018
@smoogipoo smoogipoo changed the title PassThroughInputManager needs initial state from parent PassThroughInputManager needs to receive initial state from parent Jun 29, 2018
@peppy peppy added the bounty label Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants