-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PassThroughInputManager sync with parent input state #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
peppy
changed the title
Make PassThroughInputManager syncs to parent input state
Make PassThroughInputManager sync with parent input state
Jul 10, 2018
I originally thought it is good to reset input state when |
…krctb/osu-framework into fix-pass-through-input-manager
peppy
approved these changes
Jul 11, 2018
Good job on this one. It's feeling quite solid. Make sure to claim the bounty on the original issue. |
This was referenced Mar 19, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
UseParentInput
is true, aPassThroughInputManager
syncs its keyboard and joystick state to parentInputManager
's state.For mouse buttons, only input that reached event handlers (
OnMouseDown
andOnMouseUp
) are applied. Click initiated at outside of thePassThroughInputManager
and blocked inputs are not synced. However, always syncMouseUp
to maintain an invariant (for a mouse button)this.pressed <= parent.pressed
. This is because a mouse inputs are positional and this behavior is matching to regularDrawable
s.KeyBindingContainer
handlesOnKeyDown
beforeKeyBindings
are set there was a null reference. I fixed this. However, the newKeyBindingContainer
doesn't fire actions that is bind to keys pressed while the newKeyBindingContainer
is initialized. For example, when entering osu!catch play while pressing an arrow key, the catcher isn't moving initially. I think this is allowable but maybe should fix if people need.