Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to control automatic minimising on focus loss in fullscreen mode #6094

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

Susko3
Copy link
Member

@Susko3 Susko3 commented Dec 27, 2023

Uses SDL_HINT_VIDEO_MINIMIZE_ON_FOCUS_LOSS on desktop (and iOS, but I'm not sure if it does anything).
Mobile isn't really a consideration here, as the OS has full control over "minimising a window".

Added tests that require manually alt-tabbing. Tested on windows 11 with DirectX (seamless transition) and OpenGL legacy (black screen flicker).

- applies to fullscreen only
- uses `SDL_HINT_VIDEO_MINIMIZE_ON_FOCUS_LOSS`
- mobile is not considered
Works fine on windows 11
"Minimising a window" probably isn't even valid on mobile, so default to `false`
to show that we don't ever want to try doing that.
@smoogipoo smoogipoo merged commit 768ca53 into ppy:master Dec 29, 2023
21 checks passed
@Susko3 Susko3 deleted the minimise-on-focus-loss-setting branch December 29, 2023 09:12
@THEGOLDENPRO
Copy link

Hi, I can't find this setting you are mentioning here.

It seems like ever since this feature was released my game has been launching like the image below despite it being in fullscreen mode.

Toggling fullscreen mode on and off seems to temporarily fix it but it occurs once again when I relaunch.

image

If you ever need my platform details here:

  • OS: Arch Linux x86_64
  • DE: KDE Plasma 5.27.10
  • Kernel: 6.6.9-arch1-1

Let me know if you need anything else, thank you.

@Susko3
Copy link
Member Author

Susko3 commented Jan 3, 2024

  1. This feature is not yet available, as it was merged after the latest release. When framework is updated, you'll be able to change the setting in framework.ini
  2. The issue you mentioned in unrelated to this PR. See Window resizes incorrectly on startup (Linux/Wayland) osu#26241.

@THEGOLDENPRO
Copy link

  1. This feature is not yet available, as it was merged after the latest release. When framework is updated, you'll be able to change the setting in framework.ini
  2. The issue you mentioned in unrelated to this PR. See Window resizes incorrectly on startup (Linux/Wayland) osu#26241.

ah I see, thank you for pointing me in the right direction. 👍

@peppy
Copy link
Member

peppy commented Jan 4, 2024

  1. This feature is not yet available, as it was merged after the latest release. When framework is updated, you'll be able to change the setting in framework.ini

It is planned to be exposed via settings right? I don't think we should ever recommend editing INI files directly to users.

@bdach
Copy link
Collaborator

bdach commented Jan 4, 2024

It is planned to be exposed via settings right? I don't think we should ever recommend editing INI files directly to users.

ppy/osu#26166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants