Add osu! setting to control automatic minimising on focus loss in fullscreen mode #26166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Adds the osu!-side setting to control
FrameworkSetting.MinimiseOnFocusLossInFullscreen
ConfineMouseTracker
is updated to only overrideOsuSetting.ConfineMouseMode
when clicking outside the window would minimise the windowMinimiseOnFocusLossInFullscreen == true
MinimiseOnFocusLossInFullscreen
are likely to use multiple monitors and allowing the cursor to leave the window makes sense for that use caseConfineMouseMode
toAlways
I can add tests for this to
ConfineMouseTrackerTest
, but I don't see much benefit as it's just testing the very basicConfineMouseTracker
logic.