Fix PassThroughInputManager not always releasing input
#6347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
smoogipoo
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for a
PassThroughInputManagerto receive the release event of any input at any time, it must've seen the corresponding press event, even if the press was performed whileUseParentInputis turned off.This behaviour doesn't really make sense, and is broken in osu! right now when there are drawables in front of gameplay that block input (e.g. pause overlay handling
Spacekey as the select action while playing mania whereinSpacecorresponds to the special key action).Before:
CleanShot.2024-08-02.at.10.50.48.mp4
After:
CleanShot.2024-08-02.at.10.52.49.mp4
(key is stuck in "Before" because pause overlay handled the space key press to select the continue button, but it's fixed in "After")