Fix pause input handling in osu! not working like stable #29250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try-finally has a small overhead that's unnecessary in this case given how small the code block is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PassThroughInputManagernot always releasing input osu-framework#6347 becauseTestManiaHeldInputRemainHeldAfterResumesuffers from thatIn stable, when you press the resume cursor, if there's a spinner then it's aware that you're currently pressing a key, but if there's a hit circle it does not respond to the press of that key.
This is mimicked here by removing the schedule that was implanted in 4f6c7fe in order to allow gameplay components to see the key press when pressing the resume cursor, but also add a local component somewhere in the osu! playfield to suppress the key press event from reaching any hit circle.
Existing tests were adjusted to acknowledge that pressing on the resume cursor triggers a gameplay press.