Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customising ScrollContainer's scrollbar mapping #6415

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Nov 11, 2024

For use in osu!.

@bdach
Copy link
Collaborator

bdach commented Nov 11, 2024

What's the use case?

@peppy
Copy link
Member Author

peppy commented Nov 11, 2024

ppy/osu#30579, sorry was writing things up.

@bdach bdach self-requested a review November 11, 2024 09:29
@bdach
Copy link
Collaborator

bdach commented Nov 11, 2024

My primary concern with this is that allowing this sort of override makes ScrollbarMovementExtent (which is public) sort of misleading if it is overridden the way it is in the game-side PR, because it will still appear as if the scrollbar can move the entire length of the container if reading that property, while in actuality it cannot.

Thoughts on making that protected instead or something?

@peppy
Copy link
Member Author

peppy commented Nov 11, 2024

We can try, hopefully nothing uses that in other projects.

@bdach bdach merged commit 109df77 into ppy:master Nov 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants