Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support verification state for oauth #55

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Support verification state for oauth #55

merged 3 commits into from
Jan 29, 2024

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Dec 14, 2023 •
edited by peppy
Loading

notbakaneko
notbakaneko reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a good time to add "noUncheckedIndexedAccess": true to tsconfig? 🤔

@notbakaneko
Copy link
Contributor

I didn't check to see how length checks affect anything yet, though 👀

@nanaya
Copy link
Collaborator Author

nanaya commented Dec 14, 2023

the one I removed here is literally the only one failed by the check. I can add it anyway I guess 🤷‍♀️ and maybe the entire strict option while at it (also no error)

@notbakaneko
Copy link
Contributor

I think we can turn all the strict options on; I'm not sure about noUncheckedIndexedAccess because it turns T[] into T | undefined when accessing by index regardless of any bounds checks...

notbakaneko
notbakaneko approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be deployed after migration in ppy/osu-web#10800

@notbakaneko notbakaneko mentioned this pull request Dec 19, 2023
Merged
2 tasks
@peppy peppy merged commit 2ace43b into ppy:master Jan 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notbakaneko notbakaneko notbakaneko approved these changes

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nanaya @notbakaneko @peppy