Add method for publishing messages to redis channels #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
commented
Dec 19, 2022
| public void PublishMessage<TMessage>(string channelName, TMessage message) | ||
| { | ||
| redis.GetDatabase().Publish(channelName, JsonConvert.SerializeObject(message)); | ||
| DogStatsd.Increment("messages_published", tags: new[] { $"channel:{channelName}", $"type:{typeof(TMessage).FullName}" }); |
There was a problem hiding this comment.
Dunno if this is overkill or not. Given that Redis's pubsub is a no-guarantees implementation, it felt like it may be nice to get counts from the publisher directly? I don't see datadog having anything in-house that could add this sort of tracking. Definitely think it's a good idea to have some sort of observability at a few stages of this flow to be able to diagnose failures better, though.
Merged
1 task
peppy
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the (modest) start of a series of pulls whose end goal is to develop a full no-polling flow which can be used to deliver notifications about score processing completion to lazer clients, therefore providing a facility to complete ppy/osu#18877. The general expected shape of the full flow can be previewed on this diagram.
It's mostly just one method, that is going to be used further in
osu-queue-score-statistics. The rationale of exposing it is roughly the following:ConnectionMultiplexeris intended for reuse, so I see little basis to instantiate local instances in consumer projects