Publish messages about score processing completion to redis #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
reviewed
Dec 20, 2022
| public class ScoreProcessed | ||
| { | ||
| public long ScoreId { get; init; } | ||
| public byte ProcessedVersion { get; init; } |
There was a problem hiding this comment.
I'm not sure this is going to be useful but I guess there's no harm.
peppy
reviewed
Dec 20, 2022
|
|
||
| try | ||
| { | ||
| PublishMessage("osu-channel:score:processed", new ScoreProcessed |
There was a problem hiding this comment.
Now I'm wondering if we should have put the osu-channel prefix in queue-processor...
There was a problem hiding this comment.
Let's get the process working first and tidy things up after.
There was a problem hiding this comment.
Fair cop. I'll double back on this once everything else is in place.
peppy
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step two to the proposed flow required for ppy/osu#18877.
Not much to see here either, but please do advise on data structure design, naming conventions, and error handling. I've made educated guesses but they may well turn out to be incorrect.
Notably, the amount of data in the published message is minimal, placing the burden of refetching the updated user statistics on the subscribers. This feels more versatile but also possibly inconvenient.