Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorChangeHandler doesn't handle all change types #10314

Open
peppy opened this issue Oct 1, 2020 · 1 comment
Open

EditorChangeHandler doesn't handle all change types #10314

peppy opened this issue Oct 1, 2020 · 1 comment
Labels
area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users.

Comments

@peppy
Copy link
Member

peppy commented Oct 1, 2020

It is not aware of changes outside of hitobjects. Also, since it's using a legacy encoder it is unaware of new elements in hitobjects which are not supported by the legacy format.

This can be seen on the timing screen, where changes to ControlPoints do not trigger state saving.

We either want to update this to use json serialisation/patching, or implement a more custom object equality based approach. The first option is simplest but performance may be an issue.

@peppy peppy added this to the October 2020 milestone Oct 1, 2020
@peppy peppy self-assigned this Oct 1, 2020
@peppy peppy changed the title Changes to control points in editor don't trigger change handler correctly EditorChangeHandler doesn't handle all change types Oct 8, 2020
@peppy peppy modified the milestones: October 2020, February 2021 Feb 9, 2021
@peppy peppy added the priority:1 Very important. Feels bad without fix. Affects the majority of users. label Mar 17, 2021
@peppy peppy removed this from the February 2021 milestone Apr 9, 2021
@peppy peppy removed their assignment Feb 10, 2022
@peppy
Copy link
Member Author

peppy commented Jun 13, 2022

Priority should be given to this for control points specifically, as it can be very frustrating when trying to time a beatmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users.
Projects
None yet
Development

No branches or pull requests

1 participant