-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EditorChangeHandler doesn't handle all change types #10314
Labels
Comments
This was referenced Oct 2, 2020
peppy
changed the title
Changes to control points in editor don't trigger change handler correctly
EditorChangeHandler doesn't handle all change types
Oct 8, 2020
peppy
added
the
priority:1
Very important. Feels bad without fix. Affects the majority of users.
label
Mar 17, 2021
This was referenced Apr 12, 2021
1 task
Priority should be given to this for control points specifically, as it can be very frustrating when trying to time a beatmap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
It is not aware of changes outside of hitobjects. Also, since it's using a legacy encoder it is unaware of new elements in hitobjects which are not supported by the legacy format.
This can be seen on the timing screen, where changes to
ControlPoint
s do not trigger state saving.We either want to update this to use json serialisation/patching, or implement a more custom object equality based approach. The first option is simplest but performance may be an issue.
The text was updated successfully, but these errors were encountered: