Add change handler callbacks from timing screen / components #10330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
approved these changes
Oct 4, 2020
|
|
||
| /// <summary> | ||
| /// Immediately saves the current <see cref="Editor"/> state. | ||
| /// Note that this will be a no-op if there is a change in progress via <see cref="BeginChange"/>. |
There was a problem hiding this comment.
Not relevant in the context of this PR, as the behaviour described hasn't been changed here, but I find dropping SaveState() calls entirely a bit risky, maybe? Not sure if I'm being overly paranoid but either always persisting or throwing if a change is in progress seem like better choices from an API standpoint. That said this is probably OK for now until it becomes a problem.
There was a problem hiding this comment.
If we go down that path, we'll have to re-think how some of these operations are handled. Right now, batch operations surround smaller ones and reduce the state overhead by calling Begin/End.
smoogipoo
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #10314. As @smoogipoo discovered,
EditorChangeHandler's patching doesn't support control points, so actually undoing/redoing will have no effect until that is fixed.Also, textboxes will save too many states until framework issue ppy/osu-framework#3912 is addressed. I had a local fix for this prepared, but it's probably not worth it.
I've confirmed via breakpoints that this change behaves as expected.