Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to view and adjust velocity and samples from the timeline #14742

Merged
merged 17 commits into from
Oct 15, 2021

Conversation

peppy
Copy link
Member

@peppy peppy commented Sep 14, 2021

Changing samples:

20210914 185706 (dotnet)

Changing velocity from popover:

20210914 185730 (dotnet)

Changing velocity from end shift+drag:

20210914 185811 (dotnet)

Tracking one issue with a test still, but wanted to get this PR out so it can be used to test the dependent PR #14619.

@smoogipoo
Copy link
Contributor

smoogipoo commented Oct 14, 2021

Really need to be able to undo the changes, is that possible to be done in this PR?

@peppy
Copy link
Member Author

peppy commented Oct 14, 2021

If it's not already working all signs point to "probably not" (it's already using the correct update paths such that it should work if it can), but I'll take a look.

@bdach
Copy link
Collaborator

bdach commented Oct 14, 2021

Relatively certain that having undo work with this requires #10314 for control points at least, because the beatmap patcher ignores everything but [HitObjects] sections, and so undo/redo doesn't work with the timing tab on master as is.

@peppy
Copy link
Member Author

peppy commented Oct 14, 2021

Undo isn't going to happen in this pull request.

@smoogipoo
Copy link
Contributor

Sample volume propagation doesn't work on sliders (needs to propagate to the slider head). Sliders also behave weirdly when shift+dragged really fast: https://drive.google.com/file/d/1k0MTa_a3h3ktlqVrfGaQ76JaGilRAFGY/view?usp=sharing

Can merge as is and fix these up in a separate PR if you want.

smoogipoo
smoogipoo previously approved these changes Oct 15, 2021
@peppy
Copy link
Member Author

peppy commented Oct 15, 2021

Weird, I'll try and fix the dragging one.

@peppy
Copy link
Member Author

peppy commented Oct 15, 2021

@smoogipoo can you test the dragging again? i haven't 100% fixed the underlying issue, but a early-return equality check has stopped it happening for me, so should be in a good state to get merged at least.

@smoogipoo
Copy link
Contributor

Still happens :( Maybe you can schedule + cancel this to fix? Though we intended to not throw random schedules around...

@smoogipoo smoogipoo merged commit e259357 into ppy:master Oct 15, 2021
@peppy peppy deleted the slider-timeline-velcotiy-adjust-v2 branch October 16, 2021 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to change slider velocity from compose mode
3 participants