Asynchronous data update in tournament clients cause exceptions

[cdwcgt]

Type

Crash to desktop

Bug description

regress from #24037

after 1b671b8, beatmap update will cause exceptions

Can't use GetResultSafely from inside an async operation.

this is because the code below

osu/osu.Game.Tournament/TournamentGameBase.cs

Lines 85 to 95 in 1b671b8

	protected override void LoadComplete()
	{
	GlobalCursorDisplay.MenuCursor.AlwaysPresent = true; // required for tooltip display
	// we don't want to show the menu cursor as it would appear on stream output.
	GlobalCursorDisplay.MenuCursor.Alpha = 0;
	base.LoadComplete();
	Task.Run(readBracket);
	}

readBracket() is running at thread pool so addRoundBeatmaps() and addSeedingBeatmaps() will also run in this.
so it cannot use GetResultSafely()

we can use ContinueWith to solve it like

        private bool addRoundBeatmaps()
        {
            var beatmapsRequiringPopulation = ladder.Rounds
                                                    .SelectMany(r => r.Beatmaps)
                                                    .Where(b => b.Beatmap?.OnlineID == 0 && b.ID > 0).ToList();

            if (beatmapsRequiringPopulation.Count == 0)
                return false;

            int count = 0;

            foreach (RoundBeatmap b in beatmapsRequiringPopulation)
            {
                RoundBeatmap b1 = b;
                beatmapCache.GetBeatmapAsync(b.ID).ContinueWith(task =>
                {
                    b1.Beatmap = new TournamentBeatmap(task.GetResultSafely() ?? new APIBeatmap());
                    count++;
                    updateLoadProgressMessage($"Populating round beatmaps ({count} / {beatmapsRequiringPopulation.Count})");
                });
            }

            return true;
        }

but there will something problem with updateLoadProgressMessage and saveChanges.
because thread will not wait, so addRoundBeatmaps() and addSeedingBeatmaps() will run together, so these two method will update progress message together, also it will cause saveChanges() early execution before beatmap updated.

Screenshots or videos

No response

Version

commit 1b671b8

Logs

nan

[peppy]

Where are the logs?

Where's the call stack?

Could you try posting the actual issue rather than an essay about a potential cause / solution? It would better allow actually taking action.